Repository navigation
Keep captioned video on Vulkan and cache caption fades - #1143
Merged
Merged
Conversation
Member
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1143 +/- ##
===========================================
+ Coverage 75.29% 75.34% +0.05%
===========================================
Files 283 283
Lines 39225 39286 +61
===========================================
+ Hits 29533 29601 +68
+ Misses 9692 9685 -7 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caption effects now keep Vulkan-decoded video on the GPU while adding text and fading captions.
Local benchmark: Spring at 1920×804/24 fps, six captions with one-second fades over 30 seconds. Median frame work fell from 7.75 ms to 1.87 ms across three runs with Vulkan decode/presentation in both modes. GPU captions needed 6 uploads and zero video readbacks, versus 720 uploads/readbacks for CPU captions. Both met the playback frame budget.
Includes regression coverage for grouped fades, upload reuse, CPU/GPU agreement, and H.264 native presentation/GPU export.
Trello card